Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env var renamings #1168

Merged
merged 13 commits into from
Jun 1, 2022
Merged

Env var renamings #1168

merged 13 commits into from
Jun 1, 2022

Conversation

georgimld
Copy link
Collaborator

@georgimld georgimld commented May 31, 2022 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Renamed the following env vars:

  • RPC_HOST rename to MULTICHAIN_RPC_HOST
  • RPC_PORT rename to MULTICHAIN_RPC_PORT
  • RPC_USER rename to MULTICHAIN_RPC_USER
  • RPC_PASSWORD rename to MULTICHAIN_RPC_PASSWORD
  • BACKUP_API_PORT rename to BLOCKCHAIN_PORT
  • email notification EMAIL_PORT rename to PORT (for internal use)
  • storage service STORAGE_SERVICE_PORT rename to PORT (for internal use)

Closes #999

@georgimld georgimld changed the base branch from master to 2.0.0-release May 31, 2022 12:22
@georgimld georgimld marked this pull request as ready for review May 31, 2022 14:43
@github-actions
Copy link

github-actions bot commented May 31, 2022 •
edited
Loading

Warnings
⚠️ No CHANGELOG added.

Generated by 🚫 dangerJS against 10a2aa4

@openkfwCI
Copy link

openkfwCI commented May 31, 2022 •
edited
Loading

NotesTime
❌Note for Reviewer: E2E tests on remote server failedWed, 01 Jun 2022 13:12:23 +0000

Generated by E2E-Test

@Stezido Stezido merged commit 33c1e93 into 2.0.0-release Jun 1, 2022
@Stezido Stezido deleted the 999-rename-ports branch June 8, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stezido Stezido Stezido approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename environmental variable "PORT" SP 0.5
3 participants
@georgimld @openkfwCI @Stezido