Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all apostrophe types to api string validation #1019

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

Stezido
Copy link
Contributor

@Stezido Stezido commented Nov 23, 2021

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

The api's validation on normal fields are to restrictive. In some languages apostrophes are used quite often so they should be allowed in e.g. description fields. In Id or passwords fields they are still not allowed.

@github-actions
Copy link

github-actions bot commented Nov 23, 2021

Warnings
⚠️ No CHANGELOG added.

Generated by 🚫 dangerJS against e749f83

@openkfwCI
Copy link

openkfwCI commented Nov 23, 2021

NotesTime
Note for Reviewer: E2E tests on remote server failedFri, 10 Dec 2021 17:33:41 +0000

Generated by E2E-Test

@Stezido Stezido merged commit 1d68108 into master Dec 10, 2021
@Stezido Stezido added this to the Trubudget 1.28.0 milestone Dec 10, 2021
@Stezido Stezido added api Indicates api related issue or feature bug Something isn't working labels Dec 10, 2021
@Stezido Stezido deleted the adapt-api-joi-validation branch December 10, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Indicates api related issue or feature bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants