API: Remove 'immer' dependency #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'immer' didn't really work for us and led to all kinds of hard-to-debug problems. Instead of relying on 'immer' to handle changes during event sourcing, we now carefully deep-copy relevant data in the `*_eventsourcing.ts` files and have the event-specific modules `mutate` the aggregate in-place. This makes the latter very simple; at the same time we ensure that the aggregates stored in the cache aren't changed outside the cache. Affected aggregates: - project - subproject - workflowitem
kevinbader
force-pushed
the
nimmer-immer
branch
from
bc3a97c
to
b26909d
Compare
mathiashoeld
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'immer' didn't really work for us and led to all kinds of hard-to-debug
problems. Instead of relying on 'immer' to handle changes during event
sourcing, we now carefully deep-copy relevant data in the
*_eventsourcing.tsfiles and have the event-specific modulesmutatethe aggregate in-place. This makes the latter very simple; at the same
time we ensure that the aggregates stored in the cache aren't changed
outside the cache.
Affected aggregates: