Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional configuration of nginx from env vars #1978

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

galethil
Copy link
Collaborator

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

Option for admin to add custom configuration of nginx server

How to test

  1. Check if e2e tests passed
  2. Locally change Dockerfile.dev to Dockerfile in development docker-compose
  3. Modify the new env variables
  4. After starting of app with development/start-dev.sh script (note that frontend will not work) validate that nginx config was changed properly
  5. you can use docker exec -it trubudget-dev-frontend-1 sh command and then display nginx config

Closes #1976

@openkfwCI
Copy link

openkfwCI commented Sep 17, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 60386 on remote server failedThu, 19 Sep 2024 14:15:45 +0000

Generated by E2E-Test

@SamuelPull
Copy link
Collaborator

SamuelPull commented Sep 19, 2024

Can you add increased buffer size to nginx conf please?

proxy_busy_buffers_size 512k;
proxy_buffers 4 512k;
proxy_buffer_size 256k;

@galethil galethil merged commit 226b89d into main Sep 20, 2024
30 checks passed
@SamuelPull SamuelPull deleted the 1976-additional-nginx-conf branch September 20, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional nginx configuration
3 participants