Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2028: Restrict max length of title/subtitle for project/subproject #2029

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pmolnar-dev
Copy link
Collaborator

@pmolnar-dev pmolnar-dev commented Oct 18, 2024

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

  1. login as any user
  2. Try to create new project/subproject
  3. Test if you can or cannot enter title/subtitle longer then 35 characters
  4. It should not be possible

Closes #2028

Copy link

github-actions bot commented Oct 18, 2024

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 06bb77b

@openkfwCI
Copy link

openkfwCI commented Oct 18, 2024

NotesTime
Note for Reviewer: E2E tests on pipeline 60657 on remote server failedThu, 24 Oct 2024 08:02:36 +0000

Generated by E2E-Test

@galethil
Copy link
Collaborator

@jzakotnik is 75 characters max length sufficient for the Title?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict maximum length of title/subtitle in project/subproject
3 participants