Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Send workflow item currency with subproject details #330

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

mathiashoeld
Copy link
Contributor

Changes

When the subproject details are fetched, the workflow item currency is
now returned as well.
Removed the action 'fetchWorkflowItems' as it is not used.

Closes #281

@mathiashoeld mathiashoeld force-pushed the 281-display-correct-workflowitem-currency branch from 8446edd to f45893d Compare June 17, 2019 15:23
@@ -21,7 +21,7 @@ class Identifier extends Component {
helperText={this.props.nameHintText}
value={this.props.name}
onChange={this.props.nameOnChange}
id="nameinput"
dataTest="nameinput"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave as default but also make it configurable through props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -30,7 +30,7 @@ class Identifier extends Component {
value={this.props.comment}
onChange={this.props.commentOnChange}
multiline={true}
id="commentinput"
dataTest="commentinput"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -369,6 +370,7 @@ const renderActionButtons = (
title={editDisabled ? "" : strings.common.edit}
workflowSortEnabled={workflowSortEnabled}
status={status}
dataTest="edit-workflowitem"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to pass "data-test"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const foo = ({["bar-test"]: bar}) => {
  console.log(bar)
}

const props = {
  "bar-test": "yesss"
};

foo(props)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

When the subproject details are fetched, the workflow item currency is
now returned as well.
Removed the action 'fetchWorkflowItems' as it is not used.
Add E2E-test to check this bug.

Closes #281
@mathiashoeld mathiashoeld force-pushed the 281-display-correct-workflowitem-currency branch from f45893d to 00079c7 Compare June 19, 2019 14:50
@mathiashoeld mathiashoeld merged commit 8ceea2a into master Jun 24, 2019
@mathiashoeld mathiashoeld deleted the 281-display-correct-workflowitem-currency branch June 24, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui: Currency of workflow items is not saved correctly
2 participants