api: Send workflow item currency with subproject details #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiashoeld
force-pushed
the
281-display-correct-workflowitem-currency
branch
from
8446edd
to
f45893d
Compare
gonzochic
requested changes
Jun 19, 2019
| @@ -21,7 +21,7 @@ class Identifier extends Component { | |||
| helperText={this.props.nameHintText} | |||
| value={this.props.name} | |||
| onChange={this.props.nameOnChange} | |||
| id="nameinput" | |||
| dataTest="nameinput" | |||
There was a problem hiding this comment.
leave as default but also make it configurable through props
| @@ -30,7 +30,7 @@ class Identifier extends Component { | |||
| value={this.props.comment} | |||
| onChange={this.props.commentOnChange} | |||
| multiline={true} | |||
| id="commentinput" | |||
| dataTest="commentinput" | |||
| @@ -369,6 +370,7 @@ const renderActionButtons = ( | |||
| title={editDisabled ? "" : strings.common.edit} | |||
| workflowSortEnabled={workflowSortEnabled} | |||
| status={status} | |||
| dataTest="edit-workflowitem" | |||
There was a problem hiding this comment.
is it possible to pass "data-test"?
There was a problem hiding this comment.
const foo = ({["bar-test"]: bar}) => {
console.log(bar)
}
const props = {
"bar-test": "yesss"
};
foo(props)
When the subproject details are fetched, the workflow item currency is now returned as well. Removed the action 'fetchWorkflowItems' as it is not used. Add E2E-test to check this bug. Closes #281
mathiashoeld
force-pushed
the
281-display-correct-workflowitem-currency
branch
from
f45893d
to
00079c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When the subproject details are fetched, the workflow item currency is
now returned as well.
Removed the action 'fetchWorkflowItems' as it is not used.
Closes #281