ui: Refactor lifecycle methods #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use constructor for init local state or binding event handler methods to an instance use componentdidMount for side effects after the DOM is build use componentdidUpdate for fetching data or side effects depending on an updated prop
react-router-redux is deprecated so its replaced by connected-react-router add es-lint command to overwriting rules
react-sortable-hoc is deleting array-move dep in the next major version
New release removes componentwillmount-deprecation-warning
Generated by E2E-Test |
mathiashoeld
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
React will deprecate some of their lifecycle methods. See https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html for details.
Lifecycle methods to be changed:
Tasks
Closes #384
Closes #391