ui: Change analytics access without permissions #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stezido
force-pushed
the
analytics-handle-insufficient-permissions
branch
from
ade89dc
to
f4a33be
Compare
Generated by E2E-Test |
If workflowitems are redacted the projected budget (total budget) is still visible but the charts are hidden and a well displayed warning is shown
Add helper for formating amounts to strings Add total string to table of subproject analytics
Stezido
force-pushed
the
analytics-handle-insufficient-permissions
branch
from
cbba9a5
to
320e0a1
Compare
mathiashoeld
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a user does not have the permission to see all workflowitems for all subprojects, the project analytics screen displays the message "Insufficient permissions". This is somewhat correct, since in this case the allocated and disbursed amount cannot be calculated. Since there are other values available on the permissions screen it would be a better UI experience if only the values that cannot be calculated are disabled or "redacted".
Solution
Closes #400