Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email-service: Use right environment variable for configuring smtp password #496

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Email-service: Use right environment variable for configuring smtp password #496

merged 2 commits into from
Jun 25, 2020

Conversation

Stezido
Copy link
Contributor

@Stezido Stezido commented Jun 18, 2020 •
edited
Loading

The email-service is not working properly - following changes have to be done:

  • Change config to use SMTP_USER instead of SMTP_PASSWORD for the smtp user configuration.
  • Add email-service checks to travis pipeline
  • Grant execute permissions to mutlichain-feed file after copying it into the container
  • Update knex and pg libs to newest version
  • Set env variables while nginx container build process so all env vars can be used (Currently only REACT_APP_EMAIL_SERVICE_ENABLED)
  • Show email when there already exists one in the database

@Stezido Stezido self-assigned this Jun 18, 2020
@openkfwCI
Copy link

openkfwCI commented Jun 18, 2020 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on remote server succeededThu, 25 Jun 2020 15:17:47 +0000

Generated by E2E-Test

@openkfwCI
Copy link

openkfwCI commented Jun 19, 2020 •
edited
Loading

Warnings
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 7bf4e65

@Stezido Stezido force-pushed the email-service-env-fix branch 3 times, most recently from c110657 to b43bda4 Compare June 25, 2020 11:46
@Stezido
Copy link
Contributor Author

Stezido commented Jun 25, 2020

@Reviewer e2e-tests will be added in #445

@Stezido Stezido removed their assignment Jun 25, 2020
@Stezido
Fix configuration of email-service
73411b9 
api:
- Use SMTP_USER instead of SMTP_PASSWORD for the smtp user configuration.
travis:
- Add email-service checks to travis pipeline
bc:
- Grant execute permissions to mutlichain-feed file after copying it into the container
email-service:
- Update knex and pg libs to newest version
frontend:
- Set env variable REACT_APP_EMAIL_SERVICE_ENABLED while nginx container build process
- Fetch email address when open user profile
@Stezido
Update CHANGELOG.md
7bf4e65
@Stezido Stezido merged commit c303d77 into master Jun 25, 2020
@Stezido Stezido deleted the email-service-env-fix branch July 15, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-arnauer daniel-arnauer daniel-arnauer left review comments

Assignees

@Stezido Stezido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stezido @openkfwCI @daniel-arnauer