Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator #593

Merged
merged 38 commits into from
Nov 16, 2020
Merged

Add validator #593

merged 38 commits into from
Nov 16, 2020

Conversation

daniel-arnauer
Copy link
Contributor

@daniel-arnauer daniel-arnauer commented Nov 5, 2020

Closes #572

  • When creating a workflowitem the assignee should be selectable (default: creator).
  • When creating a subproject a fixed workflowitem type should be selectable (default: any)
  • When creating a subproject a validator should be selectable (default: none)

TODO

  • fix history
  • write documentation
  • review code -> follow up ui: Refactor subproject validator/workflowitem type #620
  • adapt excel export
  • fix close button on project level and subproject level (because close permissions have been removed)
  • show close-workflowitem button only to validator/assignee of the workflowitem
  • excel export validator/workflowitem type on subproject missing

@daniel-arnauer daniel-arnauer self-assigned this Nov 5, 2020
@openkfwCI
Copy link

openkfwCI commented Nov 5, 2020

Warnings
⚠️ A new TODO was added.

Generated by 🚫 dangerJS against e4c22d1

@openkfwCI
Copy link

openkfwCI commented Nov 5, 2020

NotesTime
Note for Reviewer: E2E tests on remote server succeededMon, 16 Nov 2020 15:13:43 +0000

Generated by E2E-Test

@Stezido
Copy link
Contributor

Stezido commented Nov 5, 2020

On api workflowitems may only be closed by assignee.

TODO

  • Add same restriction for project/subproject
  • Remove notifications for workflowitem.close
  • Double check restricted Workflowitem for any changes
  • Remove workflowitem.close permission
  • Check workflowitem permission grant/revoke list endpoints
  • Add workflowitemType selection on subproject level
  • Add validator restrictions to workflowitem.close

Important Notes

  • UI: Only users can be assigned but no groups
  • API: As well users as groups can be assigned
  • API: A few permissions can still be granted and have no effect. Our validation should block them. (e.g. workflowitem.archive or workflowitem.close)
  • No changes needed regarding restricted workflowitem

daniel-arnauer and others added 18 commits November 16, 2020 10:24
Groups and users may be assigned to workflowitems and subprojects
Adapt tests and provisioning to fit the new behaviour
Auth including subproject.close and workflowitem.close intents are removed
Only assignees are allowed to close a project
Remove project.close permission
Subprojects can be created/listed with a validator field
Add more detailed error message to workflowitem eventsourcing
WorkflowitemType can now be set without any business logic
A workflowitem may only be created if the type matches the one set in the parent subproject
Add validator and workflowitem type to subproject create section
Update workflowitem close
Remove all workflowitem close permission docs
@Stezido Stezido marked this pull request as ready for review November 16, 2020 14:52
Copy link
Contributor

@Stezido Stezido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created follow up issue regarding the ui review -> #620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validator and workflowitem type field to subproject
4 participants