Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validator #593

Merged
merged 38 commits into from
Nov 16, 2020
Merged

Add validator #593

merged 38 commits into from
Nov 16, 2020

Conversation

daniel-arnauer
Copy link
Contributor

@daniel-arnauer daniel-arnauer commented Nov 5, 2020 •
edited by Stezido
Loading

Closes #572

  • When creating a workflowitem the assignee should be selectable (default: creator).
  • When creating a subproject a fixed workflowitem type should be selectable (default: any)
  • When creating a subproject a validator should be selectable (default: none)

TODO

  • fix history
  • write documentation
  • review code -> follow up ui: Refactor subproject validator/workflowitem type #620
  • adapt excel export
  • fix close button on project level and subproject level (because close permissions have been removed)
  • show close-workflowitem button only to validator/assignee of the workflowitem
  • excel export validator/workflowitem type on subproject missing

@daniel-arnauer daniel-arnauer self-assigned this Nov 5, 2020
@openkfwCI
Copy link

openkfwCI commented Nov 5, 2020 •
edited
Loading

Warnings
⚠️ A new TODO was added.

Generated by 🚫 dangerJS against e4c22d1

@openkfwCI
Copy link

openkfwCI commented Nov 5, 2020 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on remote server succeededMon, 16 Nov 2020 15:13:43 +0000

Generated by E2E-Test

@Stezido
Copy link
Contributor

Stezido commented Nov 5, 2020 •
edited
Loading

On api workflowitems may only be closed by assignee.

TODO

  • Add same restriction for project/subproject
  • Remove notifications for workflowitem.close
  • Double check restricted Workflowitem for any changes
  • Remove workflowitem.close permission
  • Check workflowitem permission grant/revoke list endpoints
  • Add workflowitemType selection on subproject level
  • Add validator restrictions to workflowitem.close

Important Notes

  • UI: Only users can be assigned but no groups
  • API: As well users as groups can be assigned
  • API: A few permissions can still be granted and have no effect. Our validation should block them. (e.g. workflowitem.archive or workflowitem.close)
  • No changes needed regarding restricted workflowitem

daniel-arnauer and others added 18 commits November 16, 2020 10:24
@Stezido
Assignee stlyes
85121f2
@Stezido
feature 1
43de75e
@Stezido
api: Workflowitems may only be closed by assignee
405d50e
@Stezido
api: Update assign behaviour
c1171af 
Groups and users may be assigned to workflowitems and subprojects
Adapt tests and provisioning to fit the new behaviour
Auth including subproject.close and workflowitem.close intents are removed
@Stezido
api: Update project assign behaviour
c146bdd 
Only assignees are allowed to close a project
Remove project.close permission
@Stezido
ui small change
febc299
@Stezido
ui fix
fd2111c
@Stezido
api: Add validator field to subproject
514be48 
Subprojects can be created/listed with a validator field
@Stezido
UI: validator and type field in subproject-create
b57708f
@Stezido
UI: send validator to API
ce43a8c
@Stezido
UI: bugfixes
2f9d99a
@Stezido
API: add valditor to workflowitem.close
169cd7e
@Stezido
UI: send suproject type to api
fc4d4a5
@Stezido
api: rearrange/rename unit tests
ec8ed35 
Add more detailed error message to workflowitem eventsourcing
@Stezido
api: Add workflowitemType to subproject
5c81d22 
WorkflowitemType can now be set without any business logic
@Stezido
api: Add business rule for workflowitem create
bb77960 
A workflowitem may only be created if the type matches the one set in the parent subproject
@Stezido
e2e: Add validator for WF e2e-test
d456a3f
@Stezido
UI: send subproject-type to api
a72831b
@Stezido
doc: Adapt user guide
f44203d 
Add validator and workflowitem type to subproject create section
Update workflowitem close
Remove all workflowitem close permission docs
@Stezido Stezido mentioned this pull request Nov 16, 2020
Closed
@Stezido Stezido marked this pull request as ready for review November 16, 2020 14:52
Stezido
Stezido approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@Stezido Stezido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created follow up issue regarding the ui review -> #620

@Stezido Stezido merged commit 567153a into master Nov 16, 2020
@Stezido Stezido deleted the add-validator branch November 17, 2020 10:41
@Stezido Stezido mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stezido Stezido Stezido approved these changes

Assignees

@Stezido Stezido

@georgimld georgimld

@daniel-arnauer daniel-arnauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validator and workflowitem type field to subproject
4 participants
@daniel-arnauer @openkfwCI @Stezido @georgimld