Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ut error in some machines without docker auth info #1640

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ABNER-1
Copy link
Member

@ABNER-1 ABNER-1 commented Jun 4, 2024

Ⅰ. Describe what this PR does

fix ut error in some machines without docker auth info
detail in #1583

Ⅱ. Does this pull request fix one issue?

fixes #1583

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from furykerry and veophi June 4, 2024 08:41
@kruise-bot kruise-bot added the size/S size/S 10-29 label Jun 4, 2024
Signed-off-by: Abner-1 <yuanyuxing.yyx@alibaba-inc.com>
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.14%. Comparing base (0d0031a) to head (befedb8).
Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
+ Coverage   47.91%   49.14%   +1.23%     
==========================================
  Files         162      183      +21     
  Lines       23491    18922    -4569     
==========================================
- Hits        11256     9300    -1956     
+ Misses      11014     8401    -2613     
  Partials     1221     1221              
Flag Coverage Δ
unittests 49.14% <ø> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@furykerry
Copy link
Member

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 145a9af into openkruise:master Jun 5, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] tag v1.6.2 unit-test TestMatchRegistryAuths case4(test4) failed
3 participants