fix: ensure server commands can be executed #368
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the ability to execute commands provided by the language server in the
vscode-playground
extension.Instead of encoding all the commands in the
package.json
file, the extension inspects theServerCapabilities
of theinitialize
response to determine which commands a server provides. It then presents a quick pick list of commands the user can choose to run.This should mean commands (that don't take any arguments at least) now "just work" with the playground extension
This PR also re-defines the example configuration keys in the
packae.json
forjson_server.py
otherwise VSCode simply responds withnull
when the configuration values are requestedCloses #365
Code review checklist (for code reviewer to complete)