fix(rdf): fixes to insert history command #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query on the `library` model that resolves `url` to `mpath` needs to also include the stele that we're querying for.
For document or collection versions we want the query times to be really fast. Since for both types of queries we do LEFT JOINS to retrieve relevant versions, index the `publication_version` and `publication_has_publication_versions` ids. Add a couple of additional indexes for the `document_change` and `library_change` tables.
It can happen (although highly unlikely) that urls aren't unique. In those cases, resolving the document_mpath will not resolve to the correct stele. To resolve, add a `stele` column to `document_element`, the same as we did for `library` model.
n-dusan
force-pushed
the
ndusan/insert-changes-fixes
branch
from
24acd05 to
ac6b0af
Compare
tombh
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly bugfixes that were figured out during testing
stelae updateon our production stele RDF repositories.urltodoc_mpathandlib_mpathcorrectly