Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-2535 Fully Type Persistence API #93

Open
wants to merge 9 commits into
base: yousuf-haque/ENG-2535-extract-persistence-interface
Choose a base branch
from
Open

ENG-2535 Fully Type Persistence API #93

wants to merge 9 commits into from

Conversation

yousuf-haque
Copy link

@yousuf-haque yousuf-haque commented Oct 12, 2023 •
edited by jira bot
Loading

Fixes # ENG-2353.

Changes proposed in this pull request:

  • This PR adds additional typing on top of the repository interfaces to simplify the mongo implementation of these interfaces

jtrein
jtrein approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@jtrein jtrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Much needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtrein jtrein jtrein approved these changes

@jdville03 jdville03 Awaiting requested review from jdville03

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yousuf-haque @jtrein