Do not render Cesium if ol3cesium is not enabled #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 on merging this soon. |
|
Looks good to me. |
petrsloup
added a commit
that referenced
this pull request
Aug 15, 2014
Do not render Cesium if ol3cesium is not enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially implements #19 -- it ensures that Cesium Scene is not rendered if not enabled (and thus not visible).
This PR does not stop ol3 rendering if the "stacked view" mode is enable (when 2d map is hidden under the Cesium). How to implement this is to be discussed (details in #19).