Merged more code into common platform #4346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ex-rzr @philipturner
This is another step in my ongoing project to eliminate as much duplicated code as possible by putting it into the common platform. This PR replaces platform-specific implementations of two more classes with common implementations: BondedUtilities and UpdateStateDataKernel. It eliminates close to 1000 lines of duplicated code. It should allow eliminating a similar amount of code from the HIP and Metal platforms. To make the corresponding changes to them,
getAllContexts()
to the ComputeContext subclass.