Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branching process in release guidelines #294

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

rf-
Copy link
Contributor

@rf- rf- commented Apr 15, 2019

This commit modifies the branching mechanics in the release guidelines in
order to simplify the process of maintaining and contributing to MDS.

The most notable changes are:

  • dev is now the target for almost all PRs, whether the changes they
    contain are breaking or non-breaking. Maintainers are responsible for
    backporting non-breaking changes from dev to the latest release
    branch after merging the PR.

  • Instead of merging changes into master and rebasing dev, master
    is reset to point to the latest release as part of the release process.
    Rebasing and merging between branches (other than PRs) are no longer
    part of the process at all.

These changes are intended to be relatively lightweight and aimed at
smoothing out pain points with the current workflow; at some point we
might want to consider more significant changes like organizing the
overall directory structure by version.

These changes would take effect for the next release after 0.3.1; we'll
want to release 0.3.1 with the existing process, rebase dev one last time,
and then follow this process going forward.

Is this a breaking change

[ ] Yes, breaking
[X] No, not breaking
[ ] I'm not sure

Provider or agency

Which API(s) will this pull request impact:
[ ] provider
[ ] agency
[X] both

This commit modifies the branching mechanics in the release guidelines in
order to simplify the process of maintaining and contributing to MDS.

The most notable changes are:

* `dev` is now the target for almost all PRs, whether the changes they
contain are breaking or non-breaking. Maintainers are responsible for
backporting non-breaking changes from `dev` to the latest release
branch after merging the PR.

* Instead of merging changes into `master` and rebasing `dev`, `master`
is reset to point to the latest release as part of the release process.
Rebasing and merging between branches (other than PRs) are no longer
part of the process at all.

These changes are intended to be relatively lightweight and aimed at
smoothing out pain points with the current workflow; at some point we
might want to consider [more significant changes] like organizing the
overall directory structure by version.

[more significant changes]: openmobilityfoundation#288 (comment)
@rf- rf- requested review from hunterowens, thekaveman and a team as code owners April 15, 2019 19:12
Copy link
Collaborator

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @rf-

I'll leave this note here, but also bring it up again in the weekly call this week: I think we can (need to) adopt the new release process for 0.3.1, since all of the work that was targeted for this release has been merged into dev rather than 0.3.x. I doesn't look like it will be a problem though, I don't see any breaking changes in dev now.

@hunterowens
Copy link
Collaborator

Given the state of 0.3.x and dev, we are gonna follow this release process. Therefore, merging!

@hunterowens hunterowens merged commit 7db82b7 into openmobilityfoundation:dev Apr 18, 2019
@hunterowens hunterowens added this to the 0.3.1 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants