AC-1062 Multiple instances of Register Patient activity #983
Conversation
|
@shubhamsgit Please have a look |
rishujam
changed the title
There was a problem hiding this comment.
I think showing a progress bar will be a better rectification as the present changes will not allow the app to inform the user that the activity is loading and the user will keep clicking on the button.
Also, can you please the android api level you encountered the bug on?
openmrs-android-sdk/build.gradle
Outdated
| buildToolsVersion "29.0.2" | ||
|
|
||
| defaultConfig { | ||
| minSdkVersion 17 | ||
| targetSdkVersion 29 | ||
| targetSdkVersion 31 |
There was a problem hiding this comment.
Any specific reason for changing the targetSdkVersion?
|
Furthermore, I would like to inform you, @rishujam, that the current version of the application is solely intended for demonstrative purposes for the implementers. Therefore, it would be more advantageous for us to focus on resolving any existing bugs within the feature modules of the application or exploring possibilities for additional functionality to be incorporated. |
|
@shubhamsgit Updated in the latest commit, Please have a look
|
|
Apologies for abusing this PR for the note, bu you have no public issue tracker. Since v2.8.4, there were only debug builds attached to releases here – 2.8.4 was the last one with a release build. Could you please rectify that? Feel free to delete this comment afterwards 😉 Thanks in advance! |
AC-1062 Multiple instances of Register Patient activity
Description of what I changed
I had to add a check before starting the navigation. So I added a navigation function in DashboardFragment which checks if one navigation is already in progress or not. Additionally, I had to upgrade the compile and target sdk version from 29 to 31 in openmrs-android-sdk build.gradle
Issue I worked on
https://issues.openmrs.org/browse/AC-1062
Checklist: I completed these to help reviewers :)
My pull request only contains ONE single commit
(the number above, next to the 'Commits' tab is 1).
I have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)