OCLOMRS-970:Automated test for creating a version, releasing it and copy subscriptionURL #724
Conversation
…opy subscriptionURL
|
|
||
|
|
||
|
|
||
|
|
||
|
|
| Before({ tags: "@concept" }, () => { | ||
| setConceptId(`CT-${nanoid()}`); | ||
| }); | ||
| Before({ tags: "@version" }, () => { |
There was a problem hiding this comment.
| Before({ tags: "@version" }, () => { | |
| Before({ tags: "@version" }, () => { |
| cy.findByRole("button", { name: /Create new version/i }).click(); | ||
| }); | ||
| Then("the user should be on the create new version dialog box", () => | ||
| cy.get("h2").contains("Create new version") |
There was a problem hiding this comment.
| cy.get("h2").contains("Create new version") | |
| cy.findByText("Create new version").should("be.visible") |
There was a problem hiding this comment.
Hi @ibacher, but this code will cause Found multiple elements with the text error. So I tried this one. Will you please suggest another idea?
There was a problem hiding this comment.
cy.findByText("Create new version", { selector: "h2" }).should("be.visible")| cy.get("h2").contains("Create new version") | ||
| ); | ||
|
|
||
| Given("the user is on the create new version dialog box", () => { |
There was a problem hiding this comment.
| Given("the user is on the create new version dialog box", () => { | |
| Given("the user clicks on the create new version dialog box", () => { |
And a similar change to the feature file.
| cy.get("#released").type("{enter}"); | ||
| }); | ||
| When("the user submits the form", () => { | ||
| cy.get("#versionForm").submit(); |
There was a problem hiding this comment.
There's no #versionForm element, so just do:
cy.findByRole("button", { name: /Submit/i }).click();|
|
||
| @dictionary | ||
| @version | ||
| Scenario: The user should be able to create a new version, release it and copy subscription URL |
There was a problem hiding this comment.
I would actually break this out as three separate tests: one to create a new version. One to release it via the checkbox, and one to copy the subscription URL. That way we should also be able to check that the user can release a new version within the "Create New Version" form.
There was a problem hiding this comment.
You are right @ibacher that's what @suruchee had but the last two scenarios were not passing probably because they needed a version to be created, she had a command for creating and getting a version the way the dictionary commands are but they were not working, so I told her that we first put those other two tests in the same scenario so that we see they pass, then we reach out to you about separating them.
There was a problem hiding this comment.
Fair enough... The version release process actually does some backend processing, so between the request to create the version returning and the version actually being created there's a bit of a delay... not much for a small dictionary, but not no time at all either.
Probably the simplest way to do this is to force Cypress to pause immediately after submitting the new version request, e.g., by using cy.wait(500). A more complicated version of the same idea would be to have a shorter pause and at the end of each pause poll the backend until a longer period of time, e.g. 8 seconds or w/e had passed.
There was a problem hiding this comment.
Here's a library to handle my "more complicated" version: https://github.com/NoriSte/cypress-wait-until. Basically looks like you can use that and wait until the backend returns that the version exists. Note that it's probably also necessary to force Cypress to reload the page.
There was a problem hiding this comment.
Thank you @hadijahkyampeire and @ibacher, I will update with the delay suggestion.
| cy.get('[type="checkbox"]').check(); | ||
| }); | ||
| When("the release dialog opens", () => { | ||
| cy.get("#confirmation-dialog-title").should("exist"); |
There was a problem hiding this comment.
| cy.get("#confirmation-dialog-title").should("exist"); | |
| cy.get("#confirmation-dialog-title").should("be.visible"); |
| cy.get("button.MuiButton-textPrimary") | ||
| .eq(1) | ||
| .click(); |
| cy.findByText(menuItem).click() | ||
| ); | ||
| Then("the subscription url should be copied", () => | ||
| cy.visit(`/users/${getUser()}/collections/${getDictionaryId()}/${getVersionId()}`) |
There was a problem hiding this comment.
I'm not sure I see how this code checks that the subscription URL was copied? This looks like a good approach to verify that the correct text was copied.
| export const getOrganisationId = () => Cypress.env("organisationId"); | ||
| export const setOrganisationId = (organisationId: string) => | ||
| Cypress.env("organisationId", organisationId); | ||
| export const getVersionId = () => Cypress.env("versionId"); | ||
| export const setVersionId = (versionId: string) => | ||
| Cypress.env("versionId", versionId); |
There was a problem hiding this comment.
| Cypress.env("versionId", versionId); | |
| Cypress.env("versionId", versionId); | |
… should be copied
|
Thank you @ibacher, for the review. I have updated the changes but I am not sure about making separate scenarios for release and copy url. |
…and copy dictionary
JIRA TICKET NAME:
The Loader-Upper
Summary:
Automated test for creating a dictionary version, releasing it, and copy subscription URL