Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve aws config docs #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

conico974
Copy link
Contributor

This is an attempt at improving the aws config with something a little bit easier to read and understand.

Not sure if it's the best way to present this, at least it's better than what we have now

### `override`

This is where you will be able to override some part of the server. For all of them you can provide what we call a `LazyLoadedOverride` which is a function that will return the override. For some example look at some [Custom overrides](custom_overrides).
All server have some default override that you can override
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All servers


### `placement`

Options to determine where the server will be deployed. On a single region or on multiple regions at the edge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option


### `override`

For default and splitted server, in addition to the options for `override` in the common options, you can also use the following options:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For both default and splitted server, in addition to override in common options, you can also use the following options listed below:

Copy link
Contributor

@sommeeeer sommeeeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some spacing under the first paragraph to make the content more visually seperated


The path to the target folder of build output from the `buildCommand` option (the path which will contain the `.next` and `.open-next` folders). This path is relative from the current process.cwd()

By default, it is set to `.`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps remove the trailing dot here.


The path to the root of the Next.js app's source code. This path is relative from the current process.cwd(). *

By default, it is set to `.`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants