fix(http): Set content-length only if body is present (#638)

opennextjs · Nov 21, 2024 · fe600ac · fe600ac
1 parent 5c0e121
commit fe600ac
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/giant-days-develop.md b/.changeset/giant-days-develop.md
@@ -0,0 +1,7 @@
+---
+"@opennextjs/aws": patch
+---
+
+fix(http): Set content-length only if body is present
+
+The body is undefined when using the edge converter and the method is GET or HEAD
diff --git a/packages/open-next/src/http/request.ts b/packages/open-next/src/http/request.ts
@@ -28,8 +28,10 @@ export class IncomingMessage extends http.IncomingMessage {
       destroy: Function.prototype,
     });
 
-    if (typeof headers["content-length"] === "undefined") {
-      headers["content-length"] = Buffer.byteLength(body).toString();
+    // Set the content length when there is a body.
+    // See https://httpwg.org/specs/rfc9110.html#field.content-length
+    if (body) {
+      headers["content-length"] ??= String(Buffer.byteLength(body));
     }
 
     Object.assign(this, {