-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nextjs 13.4.13+ Fix #208
Merged
Merged
Nextjs 13.4.13+ Fix #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2023
I hope the middleware works. 😬 I can't launch until my app is working on AWS and I'm using middleware with NextAuth.js. |
13.4.12 middleware works, there's nothing major in 13.4.13+ that would block your deployment right |
This was referenced Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #203 but rebased on
main
.Feeling cute, might delete later.
fixes: #197 #176
fixes: #189
fixes: #168
fixes: #153
fixes: #85
fixes: #51
NOTE: I have to do fixes manually for each one, for some reason doing them sequentially doesn't work atm.
This PR fixes most (there may be unknown issues but we're lacking testers to cover 100% use cases) related to Next 13.4.13+.
The latest Next 13.4.19 is working well as far as Conico and I + a couple testers know.
If this unintentionally causes a catastrophe, may Guillermo Rauch have mercy on our souls.