Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double chunk DDB batch writes to not overwhelm DDB on load #293

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Double chunk DDB batch writes to not overwhelm DDB on load #293

merged 4 commits into from
Oct 24, 2023

Conversation

dkershner6
Copy link
Contributor

@dkershner6 dkershner6 commented Oct 21, 2023 •
edited
Loading

For larger pre-rendered sites, throwing thousands of requests at DDB immediately overwhelms the throughput.

This change mitigates this.

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6cbbca3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 2:19pm

khuezy
khuezy approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@khuezy khuezy merged commit 3b6427a into opennextjs:main Oct 24, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 left review comments

@khuezy khuezy khuezy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkershner6 @khuezy @conico974