Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: XML Malformed Error DeleteObjectsCommand #300

Merged
merged 10 commits into from
Nov 2, 2023

Conversation

dkershner6
Copy link
Contributor

@dkershner6 dkershner6 commented Oct 27, 2023

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

⚠️ No Changeset found

Latest commit: 66244df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 9:48pm

@dkershner6 dkershner6 changed the title Dak/malformed xml fix: XML Malformed Error DeleteObjectsCommand Oct 27, 2023
Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like the commit history has stuff from your old branch, not sure if that'll cause any weird history.

@dkershner6
Copy link
Contributor Author

LGTM, looks like the commit history has stuff from your old branch, not sure if that'll cause any weird history.

I saw this too, but I had done a full merge. I think it is a GitHub display issue between forks, but these are in fact already merged, so it should be fine.

@khuezy khuezy merged commit ea5e302 into opennextjs:main Nov 2, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants