fix: proxy resolves once the full stream has been completed. #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackParn33
force-pushed
the
fix-proxy-resolving-before-full-response
branch
from
d975e02 to
7cfaa93
Compare
commit: |
… rather than just part of the stream
JackParn33
force-pushed
the
fix-proxy-resolving-before-full-response
branch
from
7cfaa93 to
2d6f536
Compare
khuezy
reviewed
Oct 15, 2024
No it should be totally safe, it will be piped into OpenNextNodeResponse anyway and that's the one that we await to end now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a request with the Accept-Encoding head is proxied e.g. with NextJs rewrites the response resolves before the full response has been processed.