Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protobuf to common binary formats #575

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

zdenham
Copy link
Contributor

@zdenham zdenham commented Oct 18, 2024

Came across an issue where open-next seems to be encoding application/x-protobuf in utf8 corrupting the binary.

Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: 35ce216

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@opennextjs/aws Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Should we consolidate both objects? I think they were duplicated.

@sommeeeer
Copy link
Contributor

Thanks for the PR! Should we consolidate both objects? I think they were duplicated.

We can safely remove the one in /utils (its only used in a unit test), however the one in /adapters doesn't have audio/wavaudio/webm. we should probably add that, and also change the import in the unit test. then we can safely remove the /utils one.

However after thinking about this, we should probably do the opposite? As this is a util function, and a better fit for it is the /utils folder.

Copy link

pkg-pr-new bot commented Oct 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@575

commit: 35ce216

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks
We'll figure the duplicate file later

@conico974 conico974 merged commit c8cf0fc into opennextjs:main Oct 25, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants