Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code cleanup #682

Merged
merged 1 commit into from
Dec 20, 2024
Merged

refactor: code cleanup #682

merged 1 commit into from
Dec 20, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 19, 2024

I find this version easier to read, but feel free to close...

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: f262311

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/aws@682

commit: f262311

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 23.26% 1761 / 7568
🔵 Statements 23.26% 1761 / 7568
🔵 Functions 56.83% 104 / 183
🔵 Branches 71.33% 448 / 628
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/open-next/src/build/edge/createEdgeBundle.ts 0% 0% 0% 0% 1-237
Generated in workflow #841 for commit f262311 by the Vitest Coverage Report Action

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's definitely easier to read. Thanks

@vicb vicb merged commit 0203823 into main Dec 20, 2024
3 checks passed
@vicb vicb deleted the refactor/eb branch December 20, 2024 06:09
@vicb
Copy link
Contributor Author

vicb commented Dec 20, 2024

Thanks for the review

@sommeeeer
Copy link
Contributor

Great refactor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants