feat: use the cache api if there is no kv cache available #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5cd4724 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
james-elicx
requested review from
petebacondarwin,
vicb and
dario-piotrowicz
vicb
reviewed
Nov 18, 2024
vicb
reviewed
Nov 18, 2024
packages/cloudflare/src/cli/templates/cache-handler/cache-store.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Nov 18, 2024
vicb
reviewed
Nov 18, 2024
| } | ||
| } | ||
|
|
||
| class CacheAPIStore implements CacheStore { |
There was a problem hiding this comment.
@petebacondarwin @dario-piotrowicz I'm not familiar the cf cache API, do you have thoughts about this class?
With my limited understanding of the cache API, I'm not sure if we should use it for the fetch cache (as long as the cache headers are set correctly on the fetch call).
I'm also wondering about custom keys.
james-elicx
force-pushed
the
james/cache-api-default
branch
from
d12a709 to
5cd4724
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
resolves #134