Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling, issue #149 #171

Merged
merged 5 commits into from
Apr 27, 2017
Merged

Error handling, issue #149 #171

merged 5 commits into from
Apr 27, 2017

Conversation

gmcgath
Copy link
Contributor

@gmcgath gmcgath commented Dec 10, 2016

I've made a small fix to IhdrChunk.java in the PNG module, to address issue #149 . That's the only file I've changed.

@codecov-io
Copy link

codecov-io commented Dec 10, 2016

Codecov Report

Merging #171 into integration will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##             integration    #171      +/-   ##
================================================
- Coverage           8.01%   8.01%   -0.01%     
  Complexity           497     497              
================================================
  Files                386     386              
  Lines              31371   31376       +5     
  Branches            6111    6111              
================================================
  Hits                2514    2514              
- Misses             28444   28449       +5     
  Partials             413     413
Impacted Files Coverage Δ Complexity Δ
...in/java/com/mcgath/jhove/module/png/IhdrChunk.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55f894...358a748. Read the comment docs.

@carlwilson carlwilson added this to the JHOVE hack day activities milestone Apr 27, 2017
@carlwilson carlwilson self-requested a review April 27, 2017 14:33
@carlwilson
Copy link
Member

@gmcgath this will be merged once the final update build passes.

Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gmcgath, this seems to be a discrete fix and I'll merge it. Tests would be good :)

@carlwilson carlwilson assigned carlwilson and gmcgath and unassigned carlwilson Apr 27, 2017
@carlwilson carlwilson merged commit 3bb0e9c into openpreserve:integration Apr 27, 2017
@carlwilson carlwilson added the bug A product defect that needs fixing label Apr 27, 2017
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants