Fix recently broken ModuleBase.skipBytes method #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken during incorrect merge of PR openpreserve#117. Each loop of the skip method was skipping the same amount of bytes, not subtracting the amount already skipped. Reverted to original pull request code then refactored. Fixes openpreserve#71, fixes openpreserve#193.
Codecov Report
@@ Coverage Diff @@
## integration #194 +/- ##
==============================================
- Coverage 3.45% 3.44% -0.01%
==============================================
Files 411 411
Lines 34695 34693 -2
Branches 6742 6742
==============================================
- Hits 1197 1195 -2
Misses 33403 33403
Partials 95 95
Continue to review full report at Codecov.
|
|
I'd agree regarding that minor release, I'll prepare this and merge as soon as possible. |
This was referenced Mar 20, 2017
rgfeldman
added a commit
to rgfeldman/jhove
that referenced
this pull request
Apr 10, 2019
rgfeldman
added a commit
to rgfeldman/jhove
that referenced
this pull request
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken during incorrect merge of PR #117. Each loop of the skip method was skipping the same amount of bytes, not subtracting the amount already skipped. Reverted to original pull request code then refactored. Fixes #71, fixes #193.
Since this bug is in the core JHOVE code and can affect all modules, I'd say it warrants a minor version release.