-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Exif profiles in JPEG files #253
Conversation
Add unit test cases to verify 0.2, 1.0 and 2.0 output
Add Exif version 2.21 and 2.3. Add new example file for JPEG Exif profile.
Add new error messages in JPEG module. Modify regression script to take care of modifications.
Declare more constants in test.
Correct regression expectations.
Codecov Report
@@ Coverage Diff @@
## integration #253 +/- ##
===============================================
+ Coverage 40.5% 41.6% +1.1%
- Complexity 3136 3286 +150
===============================================
Files 392 392
Lines 31474 31646 +172
Branches 6123 6165 +42
===============================================
+ Hits 12748 13167 +419
+ Misses 16337 16092 -245
+ Partials 2389 2387 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Thomas, Thanks for this. It looks a solid piece of work. So in essence its a bunch of new exif properties and the correct parsing for them and some changes to the XML handler including thread safe custom formatting for doubles. Have merged with integration and resolved the conflicts and am putting this through for a release candidate next week. All been well 1.18 will be ready for 30/11.
Best,
Carl
Hi Carl, great news that you manage to merge this pull-request... Thanks for handling this and luck for the 1.18. All the best |
This pull-request makes exif profiles be more adequately handled.
It first aims to solve #60
The different commits are intented to serialize the work.
First NisoImageMetadata and the corresponding handler have been modified to take care of many exif related attributes and to generate valid exif xml files.
Then the JpegModule and TiffModule have been modified to properly extract the ExifIFD information and merge the information from TiffIFD and ExifIFD in the resulting NisoImageMetadata.
The TiffProfileExif and TiffProfileExifIFD have been upgraded to handle 2.21 and 2.3 version of Exif
The example file from issue #60 has been added to the test-corpora to test for exif related mix generation and exif profile.