Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Exif profiles in JPEG files #253

Closed
wants to merge 7 commits into from

Conversation

tledoux
Copy link
Contributor

@tledoux tledoux commented May 12, 2017

This pull-request makes exif profiles be more adequately handled.

It first aims to solve #60

The different commits are intented to serialize the work.
First NisoImageMetadata and the corresponding handler have been modified to take care of many exif related attributes and to generate valid exif xml files.
Then the JpegModule and TiffModule have been modified to properly extract the ExifIFD information and merge the information from TiffIFD and ExifIFD in the resulting NisoImageMetadata.

The TiffProfileExif and TiffProfileExifIFD have been upgraded to handle 2.21 and 2.3 version of Exif

The example file from issue #60 has been added to the test-corpora to test for exif related mix generation and exif profile.

tledoux added 4 commits May 12, 2017 09:23
Add unit test cases to verify 0.2, 1.0 and 2.0 output
Add Exif version 2.21 and 2.3.
Add new example file for JPEG Exif profile.
Add new error messages in JPEG module.
Modify regression script to take care of modifications.
Declare more constants in test.
@tledoux tledoux self-assigned this May 12, 2017
@codecov
Copy link

codecov bot commented May 12, 2017

Codecov Report

Merging #253 into integration will increase coverage by 1.1%.
The diff coverage is 54.85%.

Impacted file tree graph

@@               Coverage Diff               @@
##             integration    #253     +/-   ##
===============================================
+ Coverage           40.5%   41.6%   +1.1%     
- Complexity          3136    3286    +150     
===============================================
  Files                392     392             
  Lines              31474   31646    +172     
  Branches            6123    6165     +42     
===============================================
+ Hits               12748   13167    +419     
+ Misses             16337   16092    -245     
+ Partials            2389    2387      -2
Impacted Files Coverage Δ Complexity Δ
...rd/hul/ois/jhove/module/jpeg/MessageConstants.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../hul/ois/jhove/module/tiff/TiffProfileExifIFD.java 92% <100%> (+48%) 11 <3> (+9) ⬆️
...a/edu/harvard/hul/ois/jhove/module/TiffModule.java 68.55% <100%> (+3.92%) 54 <0> (+3) ⬆️
...ard/hul/ois/jhove/module/tiff/TiffProfileExif.java 36.73% <27.58%> (-4.45%) 7 <1> (+2)
...edu/harvard/hul/ois/jhove/handler/TextHandler.java 0.54% <4.16%> (-0.01%) 2 <0> (ø)
.../edu/harvard/hul/ois/jhove/handler/XmlHandler.java 58.77% <48.36%> (+3.77%) 235 <2> (+58) ⬆️
...a/edu/harvard/hul/ois/jhove/module/JpegModule.java 41.63% <58.06%> (+6.75%) 72 <1> (+25) ⬆️
...du/harvard/hul/ois/jhove/module/jpeg/JpegExif.java 69.14% <68.75%> (+69.14%) 10 <3> (+10) ⬆️
...edu/harvard/hul/ois/jhove/module/tiff/ExifIFD.java 55.06% <82.35%> (+9.72%) 61 <0> (+23) ⬆️
...a/edu/harvard/hul/ois/jhove/NisoImageMetadata.java 73.78% <89.65%> (+4.1%) 173 <10> (+16) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d79018...1376e1c. Read the comment docs.

@tledoux tledoux requested a review from carlwilson May 12, 2017 11:23
Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thomas, Thanks for this. It looks a solid piece of work. So in essence its a bunch of new exif properties and the correct parsing for them and some changes to the XML handler including thread safe custom formatting for doubles. Have merged with integration and resolved the conflicts and am putting this through for a release candidate next week. All been well 1.18 will be ready for 30/11.

Best,
Carl

@tledoux
Copy link
Contributor Author

tledoux commented Oct 27, 2017

Hi Carl, great news that you manage to merge this pull-request... Thanks for handling this and luck for the 1.18.

All the best

@tledoux tledoux deleted the issue60 branch October 27, 2017 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants