Fix NPE preventing XRefStream objects being read #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A NullPointerException was being thrown when trying to validate the Index entry of any CrossRefStream dictionary. The NPEs were hidden by the method's general Exception handling, and even though the containing method was returning false, and ending file validation, no errors of any kind were being reported. This resulted in any PDF with a CrossRefStream object being reported as "Well-formed and valid" though most of the file's contents would remain unchecked.
Codecov Report
@@ Coverage Diff @@
## release-1.16 #263 +/- ##
===============================================
- Coverage 3.44% 3.44% -0.01%
===============================================
Files 411 411
Lines 34693 34695 +2
Branches 6742 6742
===============================================
Hits 1195 1195
- Misses 33403 33405 +2
Partials 95 95
Continue to review full report at Codecov.
|
|
1.16 hotfix for #258 to fix a PDF module bug. |
david-russo
approved these changes
Jul 20, 2017
- updated RELEASENOTES with hotfix details; - bumped PDF module version post-fix; and - fixed test file patching.
|
Includes and closes #258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A NullPointerException was being thrown when trying to validate the
Index entry of any CrossRefStream dictionary.
The NPEs were hidden by the method's general Exception handling, and even
though the containing method was returning false, and ending file
validation, no errors of any kind were being reported.
This resulted in any PDF with a CrossRefStream object being reported as
"Well-formed and valid" though most of the file's contents would remain
unchecked.