Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAVE: Add support for recognizing BWF v2 #273

Merged
merged 4 commits into from
Oct 24, 2017

Conversation

david-russo
Copy link
Member

@david-russo david-russo commented Sep 21, 2017

  • Simplified BWF profile detection, allowing JHOVE to detect any future BWF versions. All BWF versions will now be reported as "BWF" instead of "BWF version #", and any unrecognized version numbers will be reported as informational messages.
  • Added support for all BWF v2 fields (LoudnessValue, LoudnessRange, MaxTruePeakLevel, MaxMomentaryLoudness, and MaxShortTermLoudness).
  • Formatted the BWF v1 UMID field into a hexadecimal string instead of a long sequence of numbers.
  • Increased the minimum required Java version of JHOVE from 1.5 to 1.6 for the use of newer Array methods, and updated the build server JDK information in the README.
  • Added missing WAVE reference documentation.

- Added support for LoudnessValue, LoudnessRange, MaxTruePeakLevel,
  MaxMomentaryLoudness, and MaxShortTermLoudness BWF fields.
- Formatted the UMID field into a hexadecimal string instead of a
  long sequence of numbers.
- Simplified BWF profile detection, allowing JHOVE to detect any
  future BWF versions. All BWF versions will now be reported as "BWF"
  instead of "BWF version #", and any unrecognized version numbers will
  be reported.
- Increased the minimum required Java version from 1.5 to 1.6 for the
  use of new Array class methods, and updated build server JDK info.
@codecov
Copy link

codecov bot commented Sep 21, 2017

Codecov Report

Merging #273 into integration will decrease coverage by 0.04%.
The diff coverage is 15.03%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #273      +/-   ##
=================================================
- Coverage          41.96%   41.91%   -0.05%     
  Complexity          3275     3275              
=================================================
  Files                392      392              
  Lines              31471    31526      +55     
  Branches            6120     6133      +13     
=================================================
+ Hits               13207    13215       +8     
- Misses             15828    15875      +47     
  Partials            2436     2436
Impacted Files Coverage Δ Complexity Δ
...d/hul/ois/jhove/module/wave/BroadcastExtChunk.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/edu/harvard/hul/ois/jhove/module/iff/Chunk.java 50% <28.57%> (+8.33%) 1 <0> (ø) ⬇️
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 39.91% <33.33%> (-0.42%) 41 <0> (ø)
...a/edu/harvard/hul/ois/jhove/module/WaveModule.java 50.92% <92.3%> (+2.93%) 30 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f55b640...37acd4e. Read the comment docs.

@carlwilson carlwilson merged commit a066bbd into openpreserve:integration Oct 24, 2017
@david-russo david-russo deleted the bwf-v2 branch October 24, 2017 14:14
@carlwilson carlwilson added this to the Release v1.18 milestone Nov 6, 2017
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants