Code cleanup and PDF parser fix #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Name object names can contain characters escaped by `#` signs, where the `#` is followed by two hexadecimal values denoting the escaped character's binary representation. Prior to this change, the code would shift the first hex. value outside the range of the byte in which it belonged, and would then also attempt to interpret the decoded value as being outside of the name object, possibly delimiting the next PDF object in the file.
Codecov Report
@@ Coverage Diff @@
## integration #280 +/- ##
=================================================
+ Coverage 42.99% 43.02% +0.03%
Complexity 3425 3425
=================================================
Files 394 394
Lines 31708 31679 -29
Branches 6176 6176
=================================================
- Hits 13632 13631 -1
+ Misses 15642 15614 -28
Partials 2434 2434
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md5.planduserhomescripts.gitignorerules specific to developers' individual environments#-escaped characters in PDF name objects