Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT - ASCII Module message constants #287

Merged
merged 3 commits into from
Nov 1, 2017

Conversation

carlwilson
Copy link
Member

  • factored to module String constants.

- factored to module String constants.
@codecov
Copy link

codecov bot commented Nov 1, 2017

Codecov Report

Merging #287 into integration will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             integration     #287   +/-   ##
==============================================
  Coverage          42.97%   42.97%           
  Complexity          3425     3425           
==============================================
  Files                399      399           
  Lines              31664    31664           
  Branches            6174     6174           
==============================================
  Hits               13607    13607           
  Misses             15623    15623           
  Partials            2434     2434
Impacted Files Coverage Δ Complexity Δ
.../edu/harvard/hul/ois/jhove/module/AsciiModule.java 59.75% <0%> (ø) 19 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 098d79d...9c52481. Read the comment docs.

@carlwilson carlwilson merged commit a269aa1 into integration Nov 1, 2017
@carlwilson carlwilson deleted the refact/ascii-message-consts branch November 1, 2017 15:38
@carlwilson carlwilson added this to the Release v1.18 milestone Nov 6, 2017
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants