Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Document catalog type checking #318

Merged
merged 5 commits into from
Mar 28, 2018
Merged

Conversation

carlwilson
Copy link
Member

carlwilson and others added 3 commits March 14, 2018 09:42
- added test for document catalog `Type` key to `PdfModule`;
- added `MessageConstants` entries for catalog type checking errors;
- unit tests and test resources for functionality.
Closes #210
@codecov
Copy link

codecov bot commented Mar 16, 2018

Codecov Report

Merging #318 into integration will increase coverage by <.01%.
The diff coverage is 58.33%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #318      +/-   ##
=================================================
+ Coverage          43.52%   43.53%   +<.01%     
- Complexity          3321     3322       +1     
=================================================
  Files                367      367              
  Lines              30148    30160      +12     
  Branches            5962     5965       +3     
=================================================
+ Hits               13122    13129       +7     
- Misses             14627    14631       +4     
- Partials            2399     2400       +1
Impacted Files Coverage Δ Complexity Δ
...ard/hul/ois/jhove/module/pdf/MessageConstants.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...va/edu/harvard/hul/ois/jhove/module/PdfModule.java 70.63% <58.33%> (-0.08%) 281 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d44106...838a30d. Read the comment docs.

@carlwilson carlwilson self-assigned this Mar 16, 2018
@carlwilson carlwilson added this to the Release v1.20 milestone Mar 16, 2018
@@ -0,0 +1,105 @@
/**
*
Copy link
Member

@david-russo david-russo Mar 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty Javadoc.

@carlwilson carlwilson merged commit 053f98f into integration Mar 28, 2018
@carlwilson carlwilson deleted the fix/pdf-doc-cat-type branch March 28, 2018 22:59
rgfeldman added a commit to rgfeldman/jhove that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants