Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAVE: Report "Not well-formed" if chunk exceeds RIFF length #360

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

david-russo
Copy link
Member

@david-russo david-russo commented Sep 12, 2018

This was an existing check which failed to set an appropriate status.

Fixes #366

@david-russo david-russo added the bug A product defect that needs fixing label Sep 12, 2018
@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #360 into integration will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #360      +/-   ##
=================================================
- Coverage          45.25%   45.25%   -0.01%     
  Complexity          3457     3457              
=================================================
  Files                366      366              
  Lines              30162    30163       +1     
  Branches            5944     5944              
=================================================
  Hits               13649    13649              
- Misses             14067    14068       +1     
  Partials            2446     2446
Impacted Files Coverage Δ Complexity Δ
...a/edu/harvard/hul/ois/jhove/module/WaveModule.java 67.98% <0%> (-0.19%) 62 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a79dc0b...e70bc36. Read the comment docs.

@carlwilson carlwilson added this to the v1.22-m2 Ready milestone Dec 19, 2018
@carlwilson carlwilson removed the bug A product defect that needs fixing label Dec 19, 2018
@carlwilson carlwilson merged commit 67a531f into openpreserve:integration Jan 16, 2019
@david-russo david-russo deleted the review branch January 16, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants