Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT - HTML-hul error messages and ids #401

Merged
merged 10 commits into from
Mar 5, 2019
Merged

Conversation

carlwilson
Copy link
Member

  • added support for ResouceBundle and JhoveMessageFactor error generation;
  • add ErrorMessages.properties file with message constants; and
  • removed unneeded message constants.

- added support for `ResouceBundle` and `JhoveMessageFactor` error generation;
- add `ErrorMessages.properties` file with message constants; and
- removed unneeded message constants.
- using `JhoveMessageFactory` wrapped in `MessageConstants`.
@carlwilson carlwilson added this to the v1.22-m4 Release milestone Mar 5, 2019
@carlwilson carlwilson self-assigned this Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #401 into integration will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #401      +/-   ##
=================================================
+ Coverage          48.32%   48.34%   +0.02%     
- Complexity           934      935       +1     
=================================================
  Files                 55       55              
  Lines               7626     7626              
  Branches            1378     1378              
=================================================
+ Hits                3685     3687       +2     
+ Misses              3451     3449       -2     
  Partials             490      490
Impacted Files Coverage Δ Complexity Δ
...n/java/edu/harvard/hul/ois/jhove/ErrorMessage.java 88.23% <0%> (+11.76%) 8% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeba3f1...0745bd3. Read the comment docs.

@carlwilson carlwilson merged commit 0b3d561 into integration Mar 5, 2019
@carlwilson carlwilson deleted the feat/html-errors branch April 29, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant