Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT - PDF-hul error messages and ids #404

Merged
merged 8 commits into from
Mar 5, 2019
Merged

Conversation

carlwilson
Copy link
Member

  • added support for ResouceBundle and JhoveMessageFactor error generation;
  • added ErrorMessages.properties file with message constants;
  • using JhoveMessageFactory wrapped in MessageConstants; and
  • removed unneeded message constants.

- added support for `ResouceBundle` and `JhoveMessageFactor` error generation;
- added `ErrorMessages.properties` file with message constants;
- using `JhoveMessageFactory` wrapped in `MessageConstants`; and
- removed unneeded message constants.
@carlwilson carlwilson added this to the v1.22-m4 Release milestone Mar 5, 2019
@carlwilson carlwilson self-assigned this Mar 5, 2019
@codecov
Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #404 into integration will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             integration     #404   +/-   ##
==============================================
  Coverage          49.01%   49.01%           
  Complexity           956      956           
==============================================
  Files                 55       55           
  Lines               7626     7626           
  Branches            1378     1378           
==============================================
  Hits                3738     3738           
  Misses              3409     3409           
  Partials             479      479
Impacted Files Coverage Δ Complexity Δ
...in/java/edu/harvard/hul/ois/jhove/InfoMessage.java 41.17% <0%> (ø) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8630172...d183442. Read the comment docs.

@carlwilson carlwilson merged commit a555e3b into integration Mar 5, 2019
@carlwilson carlwilson deleted the feat/pdf-errors branch April 29, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant