Modifications in JPEG2000 module to output more info in mix formats #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tledoux
commented
Apr 10, 2019
tledoux
commented
- Add CaptureResolution property in Jhove output
- Use either CaptureResolution or DefaultDisplayResolution in mix SpatialMetrics
- Handle lossy and lossless compression scheme in mix
- Calculate the compression ratio and output it in mix
- Add layers, levels, tile size in mix:SpecialFormatCharacteristics
- Fixes Additions to JPEG2000 MIX Output #106
- Add CaptureResolution property in Jhove output - Use either CaptureResolution or DefaultDisplayResolution in mix SpatialMetrics - Handle lossy and lossless compression scheme in mix - Calculate the compression ratio and output it in mix - Add layers, levels, tile size in mix:SpecialFormatCharacteristics - Fixes openpreserve#106
Codecov Report
@@ Coverage Diff @@
## integration #445 +/- ##
=================================================
+ Coverage 49.51% 49.69% +0.17%
- Complexity 974 987 +13
=================================================
Files 55 55
Lines 7670 7750 +80
Branches 1392 1406 +14
=================================================
+ Hits 3798 3851 +53
- Misses 3416 3435 +19
- Partials 456 464 +8
Continue to review full report at Codecov.
|
carlwilson
reviewed
Apr 30, 2019
There was a problem hiding this comment.
Hi @tledoux I think that the only task that remains is to bump the version number for the JPEG Module. I'm going to run some tests and make this change then merge the PR. It'll be done for w/e 10th May.
|
Be aware the version of the JPEG2000 module should be bumped... |
carlwilson
modified the milestones:
Hack week tasks ,
Doc hack week October 2019,
v1.24-m4 Release
- copied valid JP2K corpus example output due to new MIX metadata; and - bumped version details for `JPEG2000-hul` and `XMLHandler`.
FIX - Tests for JP2K MIX Metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.