Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT - SHA-256 checksumming #497

Merged
merged 3 commits into from
Dec 9, 2019
Merged

FEAT - SHA-256 checksumming #497

merged 3 commits into from
Dec 9, 2019

Conversation

carlwilson
Copy link
Member

@carlwilson carlwilson commented Oct 17, 2019

  • added SHA-256 support to Checksummer class;
  • added SHA-256 instance to ChecksumType enum;
  • updated comments to reflect calculation of SHA-256; and
  • ignore README files when testing.

Closes #104 and includes work done in #386 thanks to @escowles

- added `SHA-256` support to `Checksummer` class;
- added `SHA-256` instance to `ChecksumType` enum;
- updated comments to reflect calculation of SHA-256; and
- ignore `README` files when testing.
@carlwilson carlwilson requested a review from tledoux October 17, 2019 12:35
@carlwilson carlwilson self-assigned this Oct 17, 2019
@carlwilson carlwilson added feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release labels Oct 17, 2019
Copy link

@escowles escowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me, thanks for resurrecting this @carlwilson !

Copy link
Contributor

@tledoux tledoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@carlwilson
Copy link
Member Author

It still requires me to come up with a test patch to add or ignore the new checksums on travis.

@carlwilson carlwilson added this to the v1.24-m4 Release milestone Oct 18, 2019
- fixed shellcheck warnings;
- using `/var/tmp` for executablility; and
- tightened test scripts.
@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #497 into integration will decrease coverage by 0.16%.
The diff coverage is 52.17%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #497      +/-   ##
=================================================
- Coverage          49.69%   49.53%   -0.17%     
+ Complexity           987      985       -2     
=================================================
  Files                 55       55              
  Lines               7750     7767      +17     
  Branches            1371     1373       +2     
=================================================
- Hits                3851     3847       -4     
- Misses              3435     3450      +15     
- Partials             464      470       +6
Impacted Files Coverage Δ Complexity Δ
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 41.52% <0%> (-0.27%) 41 <0> (ø)
...n/java/edu/harvard/hul/ois/jhove/ChecksumType.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...a/edu/harvard/hul/ois/jhove/NisoImageMetadata.java 75.64% <100%> (ø) 182 <0> (ø) ⬇️
...ain/java/edu/harvard/hul/ois/jhove/ModuleBase.java 50.34% <28.57%> (-0.36%) 70 <0> (ø)
...in/java/edu/harvard/hul/ois/jhove/Checksummer.java 56.92% <57.57%> (-10.88%) 13 <9> (ø)
...c/main/java/edu/harvard/hul/ois/jhove/RepInfo.java 53.07% <0%> (-3.08%) 36% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8725778...32243f3. Read the comment docs.

@carlwilson carlwilson merged commit 170b8e9 into integration Dec 9, 2019
@carlwilson carlwilson deleted the feat/sha-256 branch December 9, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality to be developed P2 Medium priority issues to be scheduled in a future release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance JHOVE's checksumming capabilities
3 participants