-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT - SHA-256 checksumming #497
Conversation
- added `SHA-256` support to `Checksummer` class; - added `SHA-256` instance to `ChecksumType` enum; - updated comments to reflect calculation of SHA-256; and - ignore `README` files when testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This looks good to me, thanks for resurrecting this @carlwilson !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
It still requires me to come up with a test patch to add or ignore the new checksums on travis. |
- fixed shellcheck warnings; - using `/var/tmp` for executablility; and - tightened test scripts.
Codecov Report
@@ Coverage Diff @@
## integration #497 +/- ##
=================================================
- Coverage 49.69% 49.53% -0.17%
+ Complexity 987 985 -2
=================================================
Files 55 55
Lines 7750 7767 +17
Branches 1371 1373 +2
=================================================
- Hits 3851 3847 -4
- Misses 3435 3450 +15
- Partials 464 470 +6
Continue to review full report at Codecov.
|
SHA-256
support toChecksummer
class;SHA-256
instance toChecksumType
enum;README
files when testing.Closes #104 and includes work done in #386 thanks to @escowles