WAVE / IFF: Accurate file offsets and new validation checks #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values above the printable ASCII range no longer validate, nor IDs in which spaces precede printable characters, per the IFF, AIFF, and RIFF specifications.
- Improved offset reporting - Reinstated WAVE-HUL-4 reporting - Made more strings translatable - Included reporting of unrecognized data in the top-most RIFF chunk as already existed for sub-chunks
Also stripped example wave files of unnecessary data.
Like unrecognized chunks, unrecognized list types are allowed but should be skipped, so this message is now informational. This change also allows file processing to continue after finding an unknown list, instead of aborting prematurely.
This moves constants for chunk properties such as ID and size field lengths into the Chunk class, and also adds chunk offset information for all chunks.
- Retired WAVE-HUL-16 which was a part of previously pruned dead code. - All chunk names are now surrounded by quotation marks to improve visibility of leading and trailing spaces and have been moved into translatable resource files. - Improved accuracy of WAVE messages.
- bumped version and date for `AIFF-hul`, `WAVE-hul` and `TIFF-hul`; - added version updates to baseline script; - copied `WAV-hul` module results due to wholesale changes; and - removed some text files from TIFF corpus.
Codecov Report
@@ Coverage Diff @@
## integration #534 +/- ##
=================================================
+ Coverage 49.53% 49.54% +0.01%
- Complexity 985 986 +1
=================================================
Files 55 55
Lines 7767 7765 -2
Branches 1373 1373
=================================================
Hits 3847 3847
+ Misses 3450 3448 -2
Partials 470 470
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core:
In certain circumstances submessages were being dropped when creating JhoveMessages.
IFF (AIFF & WAVE):
Check that chunk IDs only consist of characters in the printable ASCII range.
Check that spaces do not precede printable characters in chunk IDs.
Clarified error messages and improved offset reporting accuracy.
WAVE:
Added reporting for unrecognized data in the top-level RIFF structure.
Made the Table Length field of ds64 chunks optional to better align with the specification.
Reinstated WAVE-HUL-4 reporting which had been lost during refactoring.
Corrected WAVE-HUL-15 from an Error to an Informational message.
Retired WAVE-HUL-16, an unused duplicate of WAVE-HUL-19.
Clarified error messages and greatly improved offset reporting accuracy.
Moved all remaining message text into translatable resource files.
Added test files to demonstrate new validation checks.
Includes #468 from @david-russo