Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring a comment in annotations #622

Merged
merged 6 commits into from
Apr 8, 2022
Merged

Ignoring a comment in annotations #622

merged 6 commits into from
Apr 8, 2022

Conversation

samalloing
Copy link
Collaborator

Hi @carlwilson

I don't know if this is useful, but I encountered a number of these. This pull request is only for a comment in Annotations. When a comment is encountered the pdf generates an error.

Sam

samalloing and others added 2 commits June 5, 2020 18:04
Sometimes when a pdf contains a comment the pdf generates an error.
@carlwilson carlwilson requested a review from MaximPlusov April 7, 2022 16:51
@carlwilson carlwilson added bug A product defect that needs fixing P3 Low priority bugs RC1.26 labels Apr 7, 2022
@carlwilson carlwilson added this to the JHOVE 1.26 milestone Apr 7, 2022
@carlwilson
Copy link
Member

carlwilson commented Apr 7, 2022

I may be missing something here @samalloing. I'm currently merging what I can for a very imminent 1.26 release candidate. This PR doesn't seem to build as it's missing a Comment class. Care to comment ;)

@samalloing
Copy link
Collaborator Author

samalloing commented Apr 8, 2022

Hi Carl,

import edu.harvard.hul.ois.jhove.module.pdf.Comment; should be added. It is the existing Comment class

Sorry about that. Do you want me to update the pull request?

Sam

@carlwilson
Copy link
Member

Sorry about that. Do you want me to update the pull request?

If you could please, it makes it easier for me to review and merge if I'm not an author. Thanks, I will pick it up if you can't though so worry not.

Thanks @samalloing

@samalloing
Copy link
Collaborator Author

Hi Carl,

I updated the pull request. It should work now

Sam

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #622 (d448eed) into integration (c1fa732) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             integration     #622   +/-   ##
==============================================
  Coverage          45.75%   45.75%           
  Complexity          1051     1051           
==============================================
  Files                 57       57           
  Lines               9145     9145           
  Branches            1684     1684           
==============================================
  Hits                4184     4184           
  Misses              4405     4405           
  Partials             556      556           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4bf5b...d448eed. Read the comment docs.

@carlwilson carlwilson merged commit 03e35a9 into openpreserve:integration Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing P3 Low priority bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants