-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring a comment in annotations #622
Ignoring a comment in annotations #622
Conversation
Sometimes when a pdf contains a comment the pdf generates an error.
I may be missing something here @samalloing. I'm currently merging what I can for a very imminent 1.26 release candidate. This PR doesn't seem to build as it's missing a |
Hi Carl, import edu.harvard.hul.ois.jhove.module.pdf.Comment; should be added. It is the existing Comment class Sorry about that. Do you want me to update the pull request? Sam |
If you could please, it makes it easier for me to review and merge if I'm not an author. Thanks, I will pick it up if you can't though so worry not. Thanks @samalloing |
Hi Carl, I updated the pull request. It should work now Sam |
Codecov Report
@@ Coverage Diff @@
## integration #622 +/- ##
==============================================
Coverage 45.75% 45.75%
Complexity 1051 1051
==============================================
Files 57 57
Lines 9145 9145
Branches 1684 1684
==============================================
Hits 4184 4184
Misses 4405 4405
Partials 556 556 Continue to review full report at Codecov.
|
Hi @carlwilson
I don't know if this is useful, but I encountered a number of these. This pull request is only for a comment in Annotations. When a comment is encountered the pdf generates an error.
Sam