gif-hul: use ModuleBase#readUnsignedByte to read global color table #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this used the method on the DataInputStream which prevented _nByte from being incremented, causing offsets reported by messages to be offset by the size of the global color table if they occurred after it.
Codecov Report
@@ Coverage Diff @@
## integration #663 +/- ##
==============================================
Coverage 45.75% 45.75%
Complexity 1051 1051
==============================================
Files 57 57
Lines 9145 9145
Branches 1684 1684
==============================================
Hits 4184 4184
Misses 4405 4405
Partials 556 556 Continue to review full report at Codecov.
|
carlwilson
approved these changes
Apr 7, 2022
carlwilson
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this used the method on the
DataInputStreamwhich prevented_nBytefrom being incremented, causing offsets reported by messages to be offset by the size of the global color table if they occurred after it.