Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building measure property #665

Merged

Conversation

MaximPlusov
Copy link
Collaborator

@MaximPlusov MaximPlusov commented Mar 12, 2021

Fix: #662

@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #665 (29db3a0) into integration (ee730c8) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             integration     #665   +/-   ##
==============================================
  Coverage          45.76%   45.76%           
  Complexity          1051     1051           
==============================================
  Files                 57       57           
  Lines               9146     9146           
  Branches            1683     1683           
==============================================
  Hits                4186     4186           
  Misses              4405     4405           
  Partials             555      555           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12f516b...29db3a0. Read the comment docs.

Copy link
Member

@carlwilson carlwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it difficult to sign off the functionality without testing further but from a code POV that looks nice to me. Less code doing more work, properly. What's not to like? Thanks @MaximPlusov

@MaximPlusov MaximPlusov force-pushed the fix_build_measure_property branch from 5e95a05 to 2de9455 Compare April 7, 2022 08:25
@carlwilson carlwilson added bug A product defect that needs fixing P2 Medium priority issues to be scheduled in a future release RC1.26 labels Apr 7, 2022
@carlwilson carlwilson added this to the JHOVE 1.26 milestone Apr 7, 2022
@MaximPlusov MaximPlusov force-pushed the fix_build_measure_property branch from 2de9455 to 29db3a0 Compare April 7, 2022 10:42
@carlwilson carlwilson merged commit 30f66d6 into openpreserve:integration Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing P2 Medium priority issues to be scheduled in a future release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF-Hul produces Invalid Page Dictionary for PDF's with VP dictionaries
2 participants