Safely exit infinite loops on AProfile.outlinesOK / checkItemOutline

[karenhanson]

Other parts of the code have recursion detection, but here incorrect or mishandled escape characters can cause infinite loops. This change safely exits the loop and logs a message, similar to how things are handled in PDFModule.buildOutlineItemProperty - and it uses the same INFO message.

Proposing this change in relation to #652, #645, #646, #277, #473, #306. Regardless of how these backslash issues are fixed, there is a failure to exit the loop safely rather than crash JHOVE. I think we might need this or something similar.

I'm not sure why there is specific handling of the case when next is same as child here:

jhove/jhove-modules/pdf-hul/src/main/java/edu/harvard/hul/ois/jhove/module/pdf/AProfile.java

Line 869 in 47f077f

if (next.getObjNumber() != child.getObjNumber()) {

So I left that in there. It is possible this is a prior attempt to handle infinite loops... if it is we could condense my suggestion to throw the recursion info exception when any node is revisited in outlinesOK or checkItemOutline.

[codecov]

Codecov Report

Merging #704 (fcff0e2) into integration (53efb61) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             integration     #704   +/-   ##
==============================================
  Coverage          45.75%   45.75%           
  Complexity          1051     1051           
==============================================
  Files                 57       57           
  Lines               9145     9145           
  Branches            1684     1684           
==============================================
  Hits                4184     4184           
  Misses              4405     4405           
  Partials             556      556           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810728c...fcff0e2. Read the comment docs.