Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new GPSHPositioningError tag #801

Merged
merged 6 commits into from
Jan 10, 2023

Conversation

tledoux
Copy link
Contributor

@tledoux tledoux commented Nov 27, 2022

fixes #787

@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 29.21% // Head: 46.33% // Increases project coverage by +17.12% 🎉

Coverage data is based on head (6894c72) compared to base (4b61ea4).
Patch coverage: 84.61% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                 @@
##             integration     #801       +/-   ##
==================================================
+ Coverage          29.21%   46.33%   +17.12%     
- Complexity           591     1054      +463     
==================================================
  Files                 57       57               
  Lines               9079     9079               
  Branches            1609     1612        +3     
==================================================
+ Hits                2652     4207     +1555     
+ Misses              6047     4333     -1714     
- Partials             380      539      +159     
Impacted Files Coverage Δ
...a/edu/harvard/hul/ois/jhove/NisoImageMetadata.java 76.19% <84.61%> (+11.11%) ⬆️
.../java/edu/harvard/hul/ois/jhove/ConfigHandler.java 61.41% <0.00%> (+0.78%) ⬆️
...ava/org/openpreservation/jhove/ReleaseDetails.java 82.75% <0.00%> (+1.72%) ⬆️
...n/java/edu/harvard/hul/ois/jhove/PropertyType.java 100.00% <0.00%> (+4.76%) ⬆️
...rvard/hul/ois/jhove/messages/JhoveMessageImpl.java 21.42% <0.00%> (+4.76%) ⬆️
.../java/edu/harvard/hul/ois/jhove/PropertyArity.java 100.00% <0.00%> (+10.00%) ⬆️
...in/java/edu/harvard/hul/ois/jhove/HandlerBase.java 71.42% <0.00%> (+11.56%) ⬆️
...src/main/java/edu/harvard/hul/ois/jhove/Agent.java 46.82% <0.00%> (+13.49%) ⬆️
...main/java/edu/harvard/hul/ois/jhove/JhoveBase.java 41.29% <0.00%> (+18.02%) ⬆️
... and 25 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tledoux tledoux requested a review from carlwilson November 28, 2022 22:12
@carlwilson carlwilson self-assigned this Nov 30, 2022
@carlwilson carlwilson added this to the JHOVE 1.28 milestone Nov 30, 2022
@carlwilson carlwilson merged commit 48cc789 into openpreserve:integration Jan 10, 2023
@tledoux tledoux deleted the newGpsTags branch January 10, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

New GPS tag
2 participants