Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Regression tests for empty strings in PDFs. #825

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

carlwilson
Copy link
Member

No description provided.

@carlwilson carlwilson self-assigned this Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Base: 46.22% // Head: 29.18% // Decreases project coverage by -17.05% ⚠️

Coverage data is based on head (0dba54e) compared to base (f0b79d1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                 @@
##             integration     #825       +/-   ##
==================================================
- Coverage          46.22%   29.18%   -17.05%     
+ Complexity          1056      597      -459     
==================================================
  Files                 57       57               
  Lines               9057     9057               
  Branches            1607     1607               
==================================================
- Hits                4187     2643     -1544     
- Misses              4330     6033     +1703     
+ Partials             540      381      -159     
Impacted Files Coverage Δ
...n/java/edu/harvard/hul/ois/jhove/DocumentType.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/edu/harvard/hul/ois/jhove/SignatureType.java 0.00% <0.00%> (-100.00%) ⬇️
...java/edu/harvard/hul/ois/jhove/IdentifierType.java 0.00% <0.00%> (-100.00%) ⬇️
...va/edu/harvard/hul/ois/jhove/SignatureUseType.java 0.00% <0.00%> (-100.00%) ⬇️
...main/java/edu/harvard/hul/ois/jhove/Signature.java 0.00% <0.00%> (-97.06%) ⬇️
...main/java/edu/harvard/hul/ois/jhove/XMPSource.java 0.00% <0.00%> (-91.18%) ⬇️
.../main/java/edu/harvard/hul/ois/jhove/Document.java 0.00% <0.00%> (-87.88%) ⬇️
...c/main/java/edu/harvard/hul/ois/jhove/Message.java 0.00% <0.00%> (-72.00%) ⬇️
...ain/java/edu/harvard/hul/ois/jhove/Identifier.java 0.00% <0.00%> (-70.00%) ⬇️
...edu/harvard/hul/ois/jhove/ChecksumInputStream.java 0.00% <0.00%> (-68.43%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carlwilson carlwilson added the feature New functionality to be developed label Jan 20, 2023
@carlwilson carlwilson added this to the JHOVE 1.28 milestone Jan 20, 2023
@carlwilson carlwilson merged commit 1dc9f8a into integration Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality to be developed
Projects
Development

Successfully merging this pull request may close these issues.

1 participant