Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Revert XML SAXParseException reporting #850

Merged
merged 1 commit into from
Apr 18, 2023
Merged

FIX: Revert XML SAXParseException reporting #850

merged 1 commit into from
Apr 18, 2023

Conversation

carlwilson
Copy link
Member

  • reverted to exception details in the main message with Line and Column numbers in the sub-message;
  • added dedicated method for reporting SAXParseExceptions to MessageConstants; and
  • fixed integration test results for XML SAXParseException reporting.

@carlwilson
FIX: Revert XML SAXParseException reporting
0290b7e 
- reverted to exception details in the main message with Line and Column numbers in the sub-message;
- added dedicated method for reporting SAXParseExceptions to `MessageConstants`; and
- fixed integration test results for XML SAXParseException reporting.
@carlwilson carlwilson requested a review from david-russo April 18, 2023 15:04
@carlwilson carlwilson self-assigned this Apr 18, 2023
@carlwilson carlwilson added the bug A product defect that needs fixing label Apr 18, 2023
@carlwilson carlwilson added this to the JHOVE 1.28 milestone Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

❗ No coverage uploaded for pull request base (rc/1.28@04e6504). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             rc/1.28     #850   +/-   ##
==========================================
  Coverage           ?   46.98%           
  Complexity         ?     1099           
==========================================
  Files              ?       57           
  Lines              ?     9079           
  Branches           ?     1622           
==========================================
  Hits               ?     4266           
  Misses             ?     4282           
  Partials           ?      531

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@carlwilson carlwilson merged commit 11fb5d9 into rc/1.28 Apr 18, 2023
@carlwilson carlwilson deleted the fix/xml-mod-reporting branch April 18, 2023 20:11
@samalloing samalloing mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-russo david-russo Awaiting requested review from david-russo

Assignees

@carlwilson carlwilson

Labels
bug A product defect that needs fixing
Projects
None yet
Milestone
JHOVE 1.28
Development

Successfully merging this pull request may close these issues.
1 participant
@carlwilson