Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #924 by adding the invalid flag after adding a newly added Exception #925

Merged
merged 2 commits into from
Jul 31, 2024
Merged

fixes #924 by adding the invalid flag after adding a newly added Exception #925

merged 2 commits into from
Jul 31, 2024

Conversation

samalloing
Copy link
Collaborator

Hi @carlwilson
This commit fixes a bug where I forgot to set the invalid flag after a newly added Exception.

Sam

This commit fixes a bug where I forgot to set the invalid flag after an newly added Exception.
@samalloing
Copy link
Collaborator Author

Hi @carlwilson
I hoped this PR was added to 1.30, because this was an oversight of me. Can you add this soon?

Thanks

Sam

@carlwilson carlwilson added bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release labels Jul 26, 2024
@carlwilson carlwilson added this to the JHOVE 1.32 milestone Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.06%. Comparing base (838126f) to head (3ac10a6).
Report is 6 commits behind head on integration.

Additional details and impacted files
@@              Coverage Diff               @@
##             integration     #925   +/-   ##
==============================================
  Coverage          47.06%   47.06%           
  Complexity          1103     1103           
==============================================
  Files                 57       57           
  Lines               9083     9083           
  Branches            1623     1623           
==============================================
  Hits                4275     4275           
  Misses              4278     4278           
  Partials             530      530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlwilson carlwilson changed the base branch from integration to rel/1.30 July 30, 2024 15:54
@carlwilson carlwilson changed the base branch from rel/1.30 to rel/1.30.1 July 31, 2024 11:02
@carlwilson carlwilson merged commit 3e7efb5 into openpreserve:rel/1.30.1 Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing P1 High priority issues to be scheduled in the upcoming release
Projects
None yet
2 participants